View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000557 | Double Commander | Logic | public | 2012-09-06 19:29 | 2014-01-14 22:56 |
| Reporter | vitaliyg | Assigned To | Alexx2000 | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Projection | none | ETA | none | ||
| Product Version | 0.6.0 (trunk) | ||||
| Target Version | 0.5.5 | Fixed in Version | 0.5.5 | ||
| Summary | 0000557: AV when click drive button from search results tab | ||||
| Description | | DC v0.5.5 alpha Rev. 4951M -- x86_64-Win64-win32/win64 | Windows 7 SP1 x86_64 Unhandled exception: EAccessViolation: Access violation Stack trace: $00000001002FB523 line 2569, column 59 of fileviews/ufileview.pas in E:\Projects\DoubleCommander\doublecmd.exe $0000000100407904 line 142, column 3 of fileviews/ufileviewwithpanels.pas in E:\Projects\DoubleCommander\doublecmd.exe $000000010006507E line 5028, column 7 of fmain.pas in E:\Projects\DoubleCommander\doublecmd.exe $0000000100063A97 line 4785, column 3 of fmain.pas in E:\Projects\DoubleCommander\doublecmd.exe | ||||
| Steps To Reproduce | Open search dialog Search some files Send result to panel Click some drive button (AV here) | ||||
| Additional Information | NewFileSource interface is not assigned | ||||
| Tags | No tags attached. | ||||
| Attached Files | ufileview.pas.patch (1,712 bytes)
Index: src/fileviews/ufileview.pas
===================================================================
--- src/fileviews/ufileview.pas (revision 4956)
+++ src/fileviews/ufileview.pas (working copy)
@@ -2565,33 +2565,33 @@
begin
NewFileSource := FHistory.FileSource[PrevIndex];
NewPath := FHistory.Path[PrevIndex, FHistory.PathsCount[PrevIndex] - 1];
- end;
- IsNewFileSource := not NewFileSource.Equals(FileSource);
- if BeforeChangePath(NewFileSource, NewPath) then
- begin
- if IsNewFileSource then
- FileSource.RemoveReloadEventListener(@ReloadEvent);
+ if BeforeChangePath(NewFileSource, NewPath) then
+ begin
+ IsNewFileSource := not NewFileSource.Equals(FileSource);
+ if IsNewFileSource then
+ FileSource.RemoveReloadEventListener(@ReloadEvent);
- EnableWatcher(False);
+ EnableWatcher(False);
- FHistory.DeleteFromCurrentFileSource;
+ FHistory.DeleteFromCurrentFileSource;
- AfterChangePath;
+ AfterChangePath;
- if Assigned(FileSource) and IsNewFileSource then
- begin
- UpdatePath(True);
- FileSource.AddReloadEventListener(@ReloadEvent);
- end;
+ if Assigned(FileSource) and IsNewFileSource then
+ begin
+ UpdatePath(True);
+ FileSource.AddReloadEventListener(@ReloadEvent);
+ end;
- EnableWatcher(True);
+ EnableWatcher(True);
- SetActiveFile(FocusedFile);
+ SetActiveFile(FocusedFile);
- {$IFDEF DEBUG_HISTORY}
- FHistory.DebugShow;
- {$ENDIF}
+ {$IFDEF DEBUG_HISTORY}
+ FHistory.DebugShow;
+ {$ENDIF}
+ end;
end;
end;
end;
| ||||
| Fixed in Revision | 4969 | ||||
| Operating system | Windows | ||||
| Widgetset | Win32 | ||||
| Architecture | 64-bit | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-09-06 19:29 | vitaliyg | New Issue | |
| 2012-09-09 16:07 | pktfag | File Added: ufileview.pas.patch | |
| 2012-09-15 16:09 | Alexx2000 | Status | new => confirmed |
| 2012-09-15 16:09 | Alexx2000 | Target Version | => 0.5.5 |
| 2012-09-15 16:17 | Alexx2000 | Relationship added | related to 0000226 |
| 2012-09-16 21:30 | Alexx2000 | Assigned To | => Alexx2000 |
| 2012-09-16 21:30 | Alexx2000 | Status | confirmed => assigned |
| 2012-09-16 22:14 | Alexx2000 | Fixed in Revision | => 4969 |
| 2012-09-16 22:14 | Alexx2000 | Status | assigned => resolved |
| 2012-09-16 22:14 | Alexx2000 | Fixed in Version | => 0.5.5 |
| 2012-09-16 22:14 | Alexx2000 | Resolution | open => fixed |
| 2014-01-14 22:56 | Alexx2000 | Status | resolved => closed |