View Issue Details

IDProjectCategoryView StatusLast Update
0002646Double CommanderFile operationspublic2022-04-25 00:06
ReporterStepanych Assigned ToAlexx2000  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
ProjectionnoneETAnone 
Product Version0.9.10 
Target Version1.0.0Fixed in Version1.0.0 
Summary0002646: Incorrect total file copy progress
DescriptionIf the "Verify" checkbox is enabled, then when copying a large number of files, it is quite easy to notice that the total copy progress is calculated incorrectly.

Copying files completely ends if the progress shows not 100%, but less, for example, 67%. In fact, all files at this moment are indeed completely copied.
Steps To Reproduce1. Select a lot of large files (this is the easiest way to observe the copying process).
2. Press F5 and check the "Verify" checkbox.
3. Press Enter.
TagsNo tags attached.
Attached Files
screenshots.png (22,109 bytes)   
screenshots.png (22,109 bytes)   
Fixed in Revision9796
Operating systemLinux
WidgetsetQt5
Architecture64-bit

Activities

Alexx2000

2021-05-21 14:15

administrator   ~0003766

Last edited: 2021-05-21 14:19

It is a total progress of full operation not only copying. In this mode copying should ends at 50%, next 50% (from 50 to 100) is verifying.

Stepanych

2021-05-21 14:59

reporter   ~0003768

Yes, I understand that, but the point is that after

1. The file is copied, we see the total progress: 42%.
2. The copied file will be checked, we see the total progress: 44%.
3. A new file starts to be copied, we see the total progress rolled back to 42%. It looks like a bug.
...
4. On the 4th screenshot you can see how the progress of copying the last file looks like. After 2-3 seconds, copying is completely finished, but total progress is about 52-53%.

Stepanych

2022-04-19 19:56

reporter   ~0003836

Last edited: 2022-04-19 19:57

Hello. Unfortunately, the bug is not fixed in the latest version built from git (1.1.0 alpha).

Try to reproduce the bug under the following conditions:

1.avi - 1GB
2.avi - 1GB

Select and MOVE both files from one disk partition to another. I used the following options:

[x] Verify
[x] Reserve space
[x] Copy attributes
[x] Copy date/time

When moving files, you can see that the total progress is 3GB, but when the first file is moved and the second one starts moving, the total progress becomes 4GB.

It is important that I do not observe such a bug when copying. Only when moving. It is possible that you fixed it for copying, but not for moving. Therefore, you need to move from one partition to another, otherwise, if you move within the same disk partition, it will happen instantly and you will not see this bug.

And interestingly, I observe that after moving the first file, space is no longer allocated for the second and subsequent files, despite the fact that the "Reserve disk space" checkbox is checked. Space is reserved for the first file only.

Alexx2000

2022-04-24 17:51

administrator   ~0003837

Last edited: 2022-04-24 18:09

>>When moving files, you can see that the total progress is 3GB, but when the first file is moved and the second one starts moving, the total progress becomes 4GB.

No bug here, it is by design. When DC starts move first file it see that target path on another partition, so it doubles first file size (1Gb + 1Gb), that's why you see total size as 3Gb. It repeats with second file and you see 4Gb total size.

>>Space is reserved for the first file only.

Fixed.

Stepanych

2022-04-25 00:06

reporter   ~0003838

> No bug here, it is by design. When DC starts move first file it see that target path on another partition, so it doubles first file size (1Gb + 1Gb), that's why you see total size as 3Gb. It repeats with second file and you see 4Gb total size.

It's not intuitive. The total progress should be calculated before copying / moving, isn't it? And if the Verify checkbox is checked, then multiply it by two, immediately, at the very beginning of the process.

And the difference in behavior when copying and moving is also confusing.

> Fixed.

Thank you.

Issue History

Date Modified Username Field Change
2021-05-21 12:16 Stepanych New Issue
2021-05-21 14:15 Alexx2000 Note Added: 0003766
2021-05-21 14:15 Alexx2000 Status new => feedback
2021-05-21 14:18 Alexx2000 Note Edited: 0003766
2021-05-21 14:19 Alexx2000 Note Edited: 0003766
2021-05-21 14:57 Stepanych File Added: screenshots.png
2021-05-21 14:59 Stepanych Note Added: 0003768
2021-05-21 14:59 Stepanych Status feedback => new
2021-05-25 13:49 Alexx2000 Fixed in Revision => 9796
2021-05-25 13:49 Alexx2000 Assigned To => Alexx2000
2021-05-25 13:49 Alexx2000 Status new => resolved
2021-05-25 13:49 Alexx2000 Resolution open => fixed
2021-05-25 13:49 Alexx2000 Fixed in Version => 1.0.0
2021-05-25 13:49 Alexx2000 Target Version => 1.0.0
2022-04-19 19:56 Stepanych Note Added: 0003836
2022-04-19 19:56 Stepanych Note Edited: 0003836
2022-04-19 19:57 Stepanych Note Edited: 0003836
2022-04-24 17:51 Alexx2000 Note Added: 0003837
2022-04-24 18:09 Alexx2000 Note Edited: 0003837
2022-04-25 00:06 Stepanych Note Added: 0003838