View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000285Double CommanderPluginspublic2011-12-15 16:422012-04-19 20:44
Reporterphofman Assigned ToAlexx2000  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
ProjectionnoneETAnone 
PlatformLinux 
Product Version0.5.1 
Target Version0.5.4Fixed in Version0.5.4 
Summary0000285: Zip/tar plugin - Colons in source filenames corrupt the zip structure
DescriptionLinux supports colons in filenames. Typically whole pages saved by firefox contain colons in file/dir names. When trying to zip this structure using the built-in doublecmd zip plugin, it produces incorrect zips.

Example:

1. Zip files/dirs with colons using command line zip:
kosnarova@kakos:~/Dokumenty/1508531$ zip -r example-cli.zip *
  adding: MT Expert's Ten Top Tips: whatever/ (stored 0%)
  adding: MT Expert's Ten Top Tips: whatever/def_data/ (stored 0%)
  adding: MT Expert's Ten Top Tips: whatever/def_data/beacon.js (deflated 41%)
  adding: MT Expert's Ten Top Tips: whatever/def_data/quant.js (deflated 60%)
  adding: MT Expert's Ten Top Tips: whatever/dailyBullettin131%20x%201672.jpg (deflated 32%)
  adding: MT Expert's Ten Top Tips: whatever/twitter.gif (stored 0%)
  adding: MT Expert's Ten Top Tips: whatever/FACEBOOK%20131%20x%20167.jpg (deflated 34%)
  adding: MT Expert's Ten Top Tips: whatever/twitter%20131%20x%20167.jpg (deflated 31%)
  adding: MT Expert's Ten Top Tips: whatever/text.gif (stored 0%)
  adding: MT Expert's Ten Top Tips: whatever/help.gif (deflated 19%)
  adding: MT Expert's Ten Top Tips: whatever.htm (deflated 77%)

2. Verifying contents of the zip - it is correct:
kosnarova@kakos:~/Dokumenty/1508531$ unzip -l example-cli.zip
Archive: example-cli.zip
  Length Date Time Name
--------- ---------- ----- ----
        0 2011-12-15 12:38 MT Expert's Ten Top Tips: whatever/
        0 2011-12-15 11:35 MT Expert's Ten Top Tips: whatever/def_data/
     1900 2011-12-15 11:35 MT Expert's Ten Top Tips: whatever/def_data/beacon.js
     5299 2011-12-15 11:35 MT Expert's Ten Top Tips: whatever/def_data/quant.js
    44668 2011-12-15 11:35 MT Expert's Ten Top Tips: whatever/dailyBullettin131%20x%201672.jpg
      278 2011-12-15 11:35 MT Expert's Ten Top Tips: whatever/twitter.gif
    33646 2011-12-15 11:35 MT Expert's Ten Top Tips: whatever/FACEBOOK%20131%20x%20167.jpg
    40299 2011-12-15 11:35 MT Expert's Ten Top Tips: whatever/twitter%20131%20x%20167.jpg
      155 2011-12-15 11:35 MT Expert's Ten Top Tips: whatever/text.gif
      367 2011-12-15 11:35 MT Expert's Ten Top Tips: whatever/help.gif
    92477 2011-12-15 11:35 MT Expert's Ten Top Tips: whatever.htm
--------- -------
   219089 11 files

3. Zip the same data using doublecmd. The attached screenshot displays contents of the resultant zip as listed in doublecmd.

Here is contents listed in command-line zip:
kosnarova@kakos:~/Dokumenty/$ unzip -l example-doublecmd.zip
Archive: example-doublecmd.zip
  Length Date Time Name
--------- ---------- ----- ----
        0 2011-12-15 12:57 MT Expert's Ten Top Tips
        0 2011-12-15 12:57 whatever/
        0 2011-12-15 12:57 whatever/def_data/
        0 2011-12-15 12:57 whatever/def_data/beacon.js
        0 2011-12-15 12:57 whatever/def_data/quant.js
        0 2011-12-15 12:57 whatever/dailyBullettin131%20x%201672.jpg
        0 2011-12-15 12:57 whatever/twitter.gif
        0 2011-12-15 12:57 whatever/FACEBOOK%20131%20x%20167.jpg
        0 2011-12-15 12:57 whatever/twitter%20131%20x%20167.jpg
        0 2011-12-15 12:57 whatever/text.gif
        0 2011-12-15 12:57 whatever/help.gif
        0 2011-12-15 12:57 whatever.htm
--------- -------
        0 12 files

Clearly the contents is incorrect, broken by the colons.

Thanks a lot for fixing the bug in this otherwise wonderful piece of software.
TagsNo tags attached.
Attached Files
example-doublecmdzip.png (78,430 bytes)   
example-doublecmdzip.png (78,430 bytes)   
Fixed in Revision4188,4292
Operating systemLinux
Widgetset
Architecture32-bit

Activities

phofman

2011-12-16 16:10

reporter   ~0000281

Alex2000, thanks a lot for incredibly fast bugfix! :-)

Issue History

Date Modified Username Field Change
2011-12-15 16:42 phofman New Issue
2011-12-15 16:42 phofman File Added: example-doublecmdzip.png
2011-12-16 09:30 Alexx2000 Assigned To => Alexx2000
2011-12-16 09:30 Alexx2000 Status new => assigned
2011-12-16 09:43 Alexx2000 Fixed in Revision => 4188
2011-12-16 09:43 Alexx2000 Status assigned => resolved
2011-12-16 09:43 Alexx2000 Fixed in Version => 0.5.5
2011-12-16 09:43 Alexx2000 Resolution open => fixed
2011-12-16 16:10 phofman Note Added: 0000281
2012-02-11 19:40 Alexx2000 Fixed in Revision 4188 => 4188,4292
2012-02-11 19:40 Alexx2000 Fixed in Version 0.5.5 => 0.5.4
2012-02-11 19:40 Alexx2000 Target Version => 0.5.4
2012-04-19 20:44 Alexx2000 Status resolved => closed