View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000443 | Double Commander | Default | public | 2012-04-25 09:11 | 2016-06-26 12:02 |
| Reporter | Cyrax | Assigned To | cobines | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Projection | none | ETA | none | ||
| Fixed in Version | 0.5.5 | ||||
| Summary | 0000443: Annoying bug in "Configure custom columns view" dialog. | ||||
| Description | Whenever user clicks on any row in width column and then clicks on another one, value from previous row is copied onto it. Attached patch (fcolumnssetconf.pas.patch) fixes this. | ||||
| Tags | No tags attached. | ||||
| Attached Files | fcolumnssetconf.pas.patch (1,377 bytes)
Index: src/fcolumnssetconf.pas
===================================================================
--- src/fcolumnssetconf.pas (revision 4680)
+++ src/fcolumnssetconf.pas (working copy)
@@ -166,6 +166,7 @@
var Editor: TWinControl);
{Editors}
+ procedure SpinEditEnter(Sender: TObject);
procedure SpinEditExit(Sender: TObject);
procedure SpinEditChange(Sender: TObject);
procedure EditExit(Sender: TObject);
@@ -331,7 +332,6 @@
Top:=(Sender as TStringGrid).CellRect(aCol,aRow).Top;
Height:=(Sender as TStringGrid).RowHeights[aRow];
Width:=(Sender as TStringGrid).ColWidths[aCol];
- Value:=StrToInt((Sender as TStringGrid).Cells[aCol,aRow]);
end;
Editor:=updWidth;
end;
@@ -550,6 +550,7 @@
OnKeyDown := @EditorKeyDown;
OnChange := @SpinEditChange;
OnExit := @SpinEditExit;
+ OnEnter := @SpinEditEnter;
end;
@@ -657,6 +658,15 @@
AddNewField;
end;
+procedure TfColumnsSetConf.SpinEditEnter(Sender : TObject);
+Var
+ ARow, ACol : Integer;
+Begin
+ ACol := StrToIntDef((Sender as TSpinEdit).Hint, 0);
+ ARow := (Sender as TSpinEdit).Tag;
+ (Sender as TSpinEdit).Value := StrToIntDef(stgColumns.Cells[aCol,aRow], 0);
+end;
+
procedure TfColumnsSetConf.SpinEditExit(Sender: TObject);
begin
EditorSaveResult(Sender);
| ||||
| Fixed in Revision | 4687 | ||||
| Operating system | Windows | ||||
| Widgetset | Win32 | ||||
| Architecture | 64-bit | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-04-25 09:11 | Cyrax | New Issue | |
| 2012-04-25 09:11 | Cyrax | File Added: fcolumnssetconf.pas.patch | |
| 2012-04-26 15:22 | cobines | Fixed in Revision | => 4687 |
| 2012-04-26 15:22 | cobines | Note Added: 0000628 | |
| 2012-04-26 15:22 | cobines | Status | new => resolved |
| 2012-04-26 15:22 | cobines | Fixed in Version | => 0.5.5 |
| 2012-04-26 15:22 | cobines | Resolution | open => fixed |
| 2012-04-26 15:22 | cobines | Assigned To | => cobines |
| 2016-06-26 12:02 | Alexx2000 | Status | resolved => closed |