View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000565 | Double Commander | Default | public | 2012-09-10 16:37 | 2013-01-03 21:27 |
Reporter | oji | Assigned To | Alexx2000 | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Projection | none | ETA | none | ||
Platform | x64 | OS | Windows | OS Version | 7 Ultimate |
Product Version | 0.6.0 (trunk) | Product Build | 4937M | ||
Target Version | 0.5.5 | Fixed in Version | 0.5.5 | ||
Summary | 0000565: Ошибка при выделении всех найденных файлов | ||||
Description | Если запустить поиск файлов, затем вывести их на панель, а после попробовать выделить комбинацией Shift-End, то приложение вылетает с ошибкой List index (-1) out of bounds --------------- 10-09-2012, 23:33:56 --------------- | DC v0.5.5 alpha Rev. 4937M -- x86_64-Win64-win32/win64 | Windows 7 SP1 x86_64 Unhandled exception: EListError: List index (-1) out of bounds Stack trace: $0000000100081C29 in C:\Program Files\Double Commander\doublecmd.exe | ||||
Tags | No tags attached. | ||||
Attached Files | ucolumnsfileview.pas.patch (408 bytes)
Index: src/fileviews/ucolumnsfileview.pas =================================================================== --- src/fileviews/ucolumnsfileview.pas (revision 4956) +++ src/fileviews/ucolumnsfileview.pas (working copy) @@ -821,6 +821,7 @@ SetFilesDisplayItems; RedrawFiles; + dgPanelSelection(Self, 0, 1); if SetActiveFileNow(RequestedActiveFile) then RequestedActiveFile := '' else shiftend.patch (827 bytes)
Index: src/fileviews/ubrieffileview.pas =================================================================== --- src/fileviews/ubrieffileview.pas (revision 4956) +++ src/fileviews/ubrieffileview.pas (working copy) @@ -804,6 +804,7 @@ dgPanel.CalculateColumnWidth; SetFilesDisplayItems; + dgPanelSelection(Self, 0, 0); if SetActiveFileNow(RequestedActiveFile) then RequestedActiveFile := '' else Index: src/fileviews/ucolumnsfileview.pas =================================================================== --- src/fileviews/ucolumnsfileview.pas (revision 4956) +++ src/fileviews/ucolumnsfileview.pas (working copy) @@ -821,6 +821,7 @@ SetFilesDisplayItems; RedrawFiles; + dgPanelSelection(Self, 0, 1); if SetActiveFileNow(RequestedActiveFile) then RequestedActiveFile := '' else shiftend1.patch (849 bytes)
Index: src/fileviews/ubrieffileview.pas =================================================================== --- src/fileviews/ubrieffileview.pas (revision 4969) +++ src/fileviews/ubrieffileview.pas (working copy) @@ -853,6 +853,7 @@ FUpdatingActiveFile := True; dgPanel.MoveExtend(False, 0, 0); FUpdatingActiveFile := False; + dgPanelSelection(Self, 0, 0); end; procedure TBriefFileView.ClearAfterDragDrop; Index: src/fileviews/ucolumnsfileview.pas =================================================================== --- src/fileviews/ucolumnsfileview.pas (revision 4969) +++ src/fileviews/ucolumnsfileview.pas (working copy) @@ -812,6 +812,7 @@ FUpdatingActiveFile := True; dgPanel.Row := 0; FUpdatingActiveFile := False; + dgPanelSelection(Self, 0, 1); end; procedure TColumnsFileView.DisplayFileListChanged; | ||||
Fixed in Revision | 5065 | ||||
Operating system | |||||
Widgetset | |||||
Architecture | |||||
|
См. патч ucolumnsfileview.pas.patch. Я заметил еще один баг. Встаешь в начало списка, потом выделяешь все Ctrl+A, нажимаешь Shift+End, и список остается выделенным. Хотя выделение должно сняться. |
|
Проблема не только с columnsview, но и с briefview, поэтому сделал патч shiftend.patch |
|
Эти патчи попадают в ночные сборки? |
|
на выходных их включат, наверное :) |
|
Я ошибся и поставил функцию dgPanelSelection не туда, поэтому сделал новый патч shiftend1.patch |
|
В текущих билдах проблемы больше нет. |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-09-10 16:37 | oji | New Issue | |
2012-09-10 21:47 | pktfag | File Added: ucolumnsfileview.pas.patch | |
2012-09-10 21:52 | pktfag | Note Added: 0000885 | |
2012-09-10 23:12 | pktfag | File Added: shiftend.patch | |
2012-09-10 23:14 | pktfag | Note Added: 0000887 | |
2012-09-12 02:39 | oji | Note Added: 0000896 | |
2012-09-12 02:46 | pktfag | Note Added: 0000897 | |
2012-09-15 16:12 | Alexx2000 | Status | new => confirmed |
2012-09-15 16:12 | Alexx2000 | Target Version | => 0.5.5 |
2012-09-15 16:12 | Alexx2000 | Relationship added | related to 0000540 |
2012-09-20 23:23 | pktfag | File Added: shiftend1.patch | |
2012-09-20 23:24 | pktfag | Note Added: 0000924 | |
2012-10-15 16:01 | oji | Note Added: 0000951 | |
2012-10-15 16:01 | oji | Status | confirmed => closed |
2012-10-15 16:01 | oji | Resolution | open => fixed |
2012-10-15 16:01 | oji | Fixed in Version | => 0.5.5 |
2013-01-03 21:27 | Alexx2000 | Fixed in Revision | => 5065 |
2013-01-03 21:27 | Alexx2000 | Assigned To | => Alexx2000 |