View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000678 | Double Commander | File operations | public | 2013-06-20 19:20 | 2020-11-30 07:44 |
| Reporter | gatika | Assigned To | Alexx2000 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Projection | none | ETA | none | ||
| Platform | amd64 | OS | Windows | OS Version | Windows7 64bit |
| Product Version | 0.6.0 (trunk) | ||||
| Target Version | 0.8.0 | Fixed in Version | 0.8.0 | ||
| Summary | 0000678: File type converter for viewer not working | ||||
| Description | I found out, that the file conversion for the internal file viewer is not working on my 46bit windows7 system. This was because of the noconsole flag, which denies access to the pipe of the console. Find attached an patch, which solves this problem for me. | ||||
| Steps To Reproduce | Define a file converter for the internal viewer. If you open the viewer you get an empty view. | ||||
| Tags | No tags attached. | ||||
| Attached Files | nocnosole.patch (662 bytes)
Index: ushellexecute.pas
===================================================================
--- ushellexecute.pas (Revision 5214)
+++ ushellexecute.pas (Arbeitskopie)
@@ -483,7 +483,12 @@
Process:= TProcessUTF8.Create(nil);
try
Process.CommandLine:= FormatShell(sCmdLine);
- Process.Options:= [poNoConsole, poWaitOnExit];
+ //GAILJ
+ //poNoConsole corrupts the redirection into the temporary file!
+ //Process.Options:= [poNoConsole, poWaitOnExit];
+ Process.Options:= [poWaitOnExit];
+ //optional
+ //Process.ShowWindow:=swoHide;
Process.Execute;
finally
Process.Free;
| ||||
| Fixed in Revision | 7752, 7753 | ||||
| Operating system | Windows | ||||
| Widgetset | Win32 | ||||
| Architecture | 64-bit | ||||
|
|
I came into similar issue today which probably has the same root cause. A try to copy a file which is a pipe hangs the whole DC. strace shows it's on open() system function. This is very problematic if you try to copy a big dictionary which can contain some pipes. DC will hang on every one. Tested on Linux, Fedora 25. Steps to reproduce: 1. mkfifo foo 2. Try to view or copy it with DC |
|
|
Your issue is not related with this issue. DC cannot copy special files: pipes, device files etc. |
|
|
DC should not hang of pipes anyway. Created 0001795. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-06-20 19:20 | gatika | New Issue | |
| 2013-06-20 19:20 | gatika | File Added: nocnosole.patch | |
| 2017-02-08 08:01 | Alexx2000 | Target Version | => 0.8.0 |
| 2017-04-16 00:41 | szpak | Note Added: 0002154 | |
| 2017-04-16 14:33 | Alexx2000 | Note Added: 0002155 | |
| 2017-04-16 14:35 | Alexx2000 | Status | new => acknowledged |
| 2017-04-17 17:50 | szpak | Note Added: 0002161 | |
| 2017-08-20 11:38 | Alexx2000 | Fixed in Revision | => 7752 |
| 2017-08-20 11:38 | Alexx2000 | Status | acknowledged => resolved |
| 2017-08-20 11:38 | Alexx2000 | Resolution | open => fixed |
| 2017-08-20 11:38 | Alexx2000 | Assigned To | => Alexx2000 |
| 2017-08-20 13:21 | Alexx2000 | Fixed in Revision | 7752 => 7752, 7753 |
| 2017-08-20 13:21 | Alexx2000 | Fixed in Version | => 0.8.0 |
| 2020-11-30 07:44 | Alexx2000 | Status | resolved => closed |
