View Issue Details

IDProjectCategoryView StatusLast Update
0000998Double CommanderFile operationspublic2018-11-10 22:36
ReporterEagleXK Assigned To 
PrioritylowSeverityfeatureReproducibilityN/A
Status newResolutionopen 
ProjectionnoneETAnone 
Product Version0.5.11 
Summary0000998: Compare folders
DescriptionCurrently the function compare folders works only by modified date. I think it is not correct because if there are two files with same date but different sizes no one will be selected (must be both of them). Also there are no dialog if files in folders are identical (and there can be a information that there are files with same date and different size).
TagsNo tags attached.
Attached Files
Fixed in Revision
Operating system
Widgetset
Architecture

Activities

w2017

2018-10-21 18:41

reporter   ~0002810

v0.8.4 still ignores file differences when comparing directories.
I agree with the OP that both files should be selected in such a case.

I also agree that showing a message if compared directories are identical would be nice, but the "information that there are files with same date and different size" is not clear to me. TC does not show anything special in such a case either ;-)

cordylus

2018-10-23 20:15

developer   ~0002830

0.8.4 can compare by content (see the checkbox with the same name) that works as expected.

"Information that there are files with same date and different size" is available at the bottom as the number of different files when "by content" is on. The files that were considered newer or older are not counted there.

The only actual part of the bug is "no dialog if files in folders are identical", but that is a questionable request, currently you can check whether the number of files found is equal to the number of identical. But it won't tell you if the directory structure is different (neither the bug description asks for this), so adding a message may be misleading for the user.

w2017

2018-11-10 20:33

reporter   ~0002902

Maybe I misunderstood, but I tested the menu "Mark/Compare directories" (see 1st screen shot). The issue is with the 3rd file in the screen shot, which is NOT marked at any side. (I am using DC v.0.8.4 under Ubuntu LTS 18.04)

If the dates are different, then the file size indeed should be ignored. But if the date+time are exactly the same, then the file size should be compared as well and if the sizes are different then both sides should be marked.

TC 9.12 under Wine does exactly that (see 2nd screen shot).

As that would change established behavior of DC that probably needs an extra option under "Behaviors"?
E.g. "Mark/Compare Directories: identical Date/Time compares file size too" (I cannot think of a shorter option name :-)

cordylus

2018-11-10 22:36

developer   ~0002905

My bad, I've thought it was about "Synchronize dirs..." window, I'm using that to compare directories usually. Yes, you are right, the issue is valid.

Issue History

Date Modified Username Field Change
2015-01-29 10:03 EagleXK New Issue
2018-10-21 18:41 w2017 Note Added: 0002810
2018-10-23 20:15 cordylus Note Added: 0002830
2018-11-10 20:09 w2017 File Added: 2018-11-11 DC compare directories.png
2018-11-10 20:33 w2017 Note Added: 0002902
2018-11-10 20:33 w2017 File Added: 2018-11-11 TC compare directories.png
2018-11-10 22:36 cordylus Note Added: 0002905